Skip to content

add edit tool formatters - #1018

Merged
LasmarKhalifa merged 1 commit into
mainfrom
07-02/pi-tool-formatter-edit
Aug 5, 2026
Merged

add edit tool formatters#1018
LasmarKhalifa merged 1 commit into
mainfrom
07-02/pi-tool-formatter-edit

Conversation

@LasmarKhalifa

@LasmarKhalifa LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Closes #1026

LasmarKhalifa commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 852ae68 to f2399f0 Compare July 3, 2026 14:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from 2d3ce63 to 7730ee2 Compare July 3, 2026 14:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from f2399f0 to 4166e5d Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from 7730ee2 to 676a57b Compare July 3, 2026 15:30
@LasmarKhalifa
LasmarKhalifa marked this pull request as ready for review July 3, 2026 16:30

@mathiusj mathiusj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit formatters look good. Two small things.

Comment thread lib/roast/cogs/agent/providers/pi/messages/tool_call_message.rb
Comment thread lib/roast/cogs/agent/providers/pi/messages/tool_result_message.rb
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from 676a57b to 6401f99 Compare July 10, 2026 15:23
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch 2 times, most recently from 1d5f2cb to 58bc7d6 Compare July 10, 2026 15:50
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch 2 times, most recently from 27d834e to 9f3ab5a Compare July 10, 2026 16:13
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 58bc7d6 to 0c38e90 Compare July 10, 2026 16:13
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from 9f3ab5a to a161e59 Compare July 10, 2026 16:33
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 0c38e90 to 5e31fef Compare July 10, 2026 16:33
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from a161e59 to a785239 Compare July 10, 2026 16:38
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 5e31fef to 32856c2 Compare July 10, 2026 16:38
@LasmarKhalifa LasmarKhalifa linked an issue Jul 13, 2026 that may be closed by this pull request
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 32856c2 to 80dee98 Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from a785239 to d3310c0 Compare July 14, 2026 20:37
@LasmarKhalifa
LasmarKhalifa force-pushed the 06-30/pi-tool-formatter-write branch from 80dee98 to d27fc00 Compare July 30, 2026 14:41
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from d3310c0 to 275a3f7 Compare July 30, 2026 14:41

LasmarKhalifa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Aug 5, 3:41 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 5, 3:49 PM UTC: Graphite rebased this pull request as part of a merge.
  • Aug 5, 3:50 PM UTC: @LasmarKhalifa merged this pull request with Graphite.

@LasmarKhalifa
LasmarKhalifa changed the base branch from 06-30/pi-tool-formatter-write to graphite-base/1018 August 5, 2026 15:46
@LasmarKhalifa
LasmarKhalifa changed the base branch from graphite-base/1018 to main August 5, 2026 15:47
@LasmarKhalifa
LasmarKhalifa force-pushed the 07-02/pi-tool-formatter-edit branch from 275a3f7 to 2fec6f4 Compare August 5, 2026 15:48
@LasmarKhalifa
LasmarKhalifa merged commit 5afb201 into main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pi format_edit tool implementation

2 participants